Skip to content

Run CircleCi with BUILD=debug#7528

Merged
dlang-bot merged 2 commits intodlang:masterfrom
wilzbach:circleci-debug
Mar 29, 2020
Merged

Run CircleCi with BUILD=debug#7528
dlang-bot merged 2 commits intodlang:masterfrom
wilzbach:circleci-debug

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Dec 26, 2017 •
edited
Loading

From @jacob-carlborg on Slack:

I’ve noticed that when compiling DMD in debug mode and running the test the following assertion fails: https://github.com/dlang/dmd/blob/master/src/dmd/dmangle.d#L587
the assertion fails due to one of characters in the mangled name contains a -. Is it the assertion that needs to be updated or is the mangling wrong?
since we’re not testing the compiler in debug mode, as far as I understand, and everything seems to be working I’m guessing the assertion needs to be updated
feels slightly pointless to me with the debug code if it’s never run

This just opens the PR with BUILD=debug. We still need to fix the error in debug mode, but this can be done independently.

@dlang-bot
Copy link
Contributor

dlang-bot commented Dec 26, 2017 •
edited
Loading

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#7528"

@wilzbach
Copy link
Contributor Author

wilzbach commented Dec 26, 2017

"Good news - the testsuite is really failing:

 ... runnable/test2.sh
core.exception.AssertError@dmd/dmangle.d(587): Assertion failure
----------------
src/core/exception.d:437 onAssertError [0x857548]
src/core/exception.d:633 _d_assertp [0x8462f2]
dmd/dmangle.d:587 _ZN7Mangler5visitEP11Declaration [0x56e5a0]
dmd/dmangle.d:685 _ZN7Mangler11mangleExactEP15FuncDeclaration [0x56e935]
dmd/dmangle.d:1101 _Z11mangleExactP15FuncDeclaration [0x5702e2]
dmd/tocsym.d:304 _ZN8toSymbol8ToSymbol5visitEP15FuncDeclaration [0x6d791e]
dmd/parsetimevisitor.d:53 _ZN16ParseTimeVisitorI10ASTCodegenE5visitEP19UnitTestDeclaration [0x6a9603]
dmd/func.d:3508 _ZN19UnitTestDeclaration6acceptEP7Visitor [0x60c4d7]
dmd/tocsym.d:444 _Z8toSymbolP7Dsymbol [0x6d6f8f]
dmd/glue.d:818 _Z25FuncDeclaration_toObjFileP15FuncDeclarationb [0x6cf1cd]
dmd/toobj.d:311 _ZN9toObjFile9ToObjFile5visitEP15FuncDeclaration [0x6e233a]
dmd/parsetimevisitor.d:53 _ZN16ParseTimeVisitorI10ASTCodegenE5visitEP19UnitTestDeclaration [0x6a9603]
dmd/func.d:3508 _ZN19UnitTestDeclaration6acceptEP7Visitor [0x60c4d7]
dmd/toobj.d:1369 _Z9toObjFileP7Dsymbolb [0x6e2277]
dmd/glue.d:411 _Z10genObjFileP6Moduleb [0x6ce50e]
dmd/mars.d:1019 int dmd.mars.tryMain(ulong, const(char)**) [0x646bf4]
dmd/mars.d:1124 _Dmain [0x64768a]
executing with args: 
DMD v2.078.0-beta.1-76-g822e4fa-dirty DEBUG
Makefile:193: recipe for target 'test_results/runnable/test2.sh.out' failed

For those not using #dmd on Slack, this is due to #6727

@wilzbach wilzbach mentioned this pull request Jan 4, 2018
Closed
@wilzbach wilzbach mentioned this pull request Jul 1, 2018
Merged
@wilzbach wilzbach force-pushed the circleci-debug branch 2 times, most recently from 8da91c2 to 7a42a0d Compare July 9, 2018 08:51
@wilzbach
Copy link
Contributor Author

wilzbach commented Dec 21, 2018

(rebased)

jacob-carlborg
jacob-carlborg reviewed Dec 21, 2018
View reviewed changes
@wilzbach wilzbach mentioned this pull request Jan 8, 2019
Closed
@wilzbach wilzbach mentioned this pull request Jul 27, 2019
Merged
@MoonlightSentinel
Copy link
Contributor

MoonlightSentinel commented Dec 17, 2019 •
edited
Loading

Can we move forward with this to avoid situations like #10656?

@thewilsonator
Copy link
Contributor

thewilsonator commented Mar 29, 2020

cp: cannot stat 'generated/linux/debug/64/dmd.conf': No such file or directory

Maybe the .conf generation also needs to be redirected also?

@MoonlightSentinel
Copy link
Contributor

MoonlightSentinel commented Mar 29, 2020 •
edited
Loading

It should work as is but build.d skipped dmd.conf for unknown reasons...

@Geod24
Copy link
Member

Geod24 commented Mar 29, 2020

Can we get those PRs rebased instead of creating merge commits please ?

@MoonlightSentinel MoonlightSentinel mentioned this pull request Mar 29, 2020
Merged
@MoonlightSentinel
Copy link
Contributor

MoonlightSentinel commented Mar 29, 2020 •
edited
Loading

Agreed but I used the web interface because GitHub previously rejected my rebase complaining about runnable_cxx.yml (creating such files in other repos is probably rejected for security reasons).

EDIT; Rebase worked after merging.

wilzbach and others added 2 commits March 29, 2020 18:13
@dlang-bot dlang-bot merged commit 327d042 into dlang:master Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoonlightSentinel MoonlightSentinel MoonlightSentinel left review comments

@Geod24 Geod24 Geod24 approved these changes

@PetarKirov PetarKirov PetarKirov approved these changes

+1 more reviewer

@jacob-carlborg jacob-carlborg jacob-carlborg left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Infrastructure:Continuous Integration Merge:auto-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@wilzbach @dlang-bot @MoonlightSentinel @thewilsonator @Geod24 @jacob-carlborg @PetarKirov @JinShil